fix: Job create cannot be saved without setting interval #4423
Conversation
| @@ -4,7 +4,7 @@ import InputWithUnit from '@/components/Form/FormFields/InputWithUnit.vue' | |||
| import store from '@/store' | |||
|
|
|||
| const validatorInterval = (rule, value, callback) => { | |||
| if (isNaN(parseInt(value, 10)) || parseInt(value) < 1) { | |||
| if (!isNaN(parseInt(value, 10)) && parseInt(value) < 1) { | |||
| return callback(new Error(i18n.t('EnsureThisValueIsGreaterThanOrEqualTo1'))) | |||
| } | |||
| callback() | |||
There was a problem hiding this comment.
The only difference between the two versions of the given code snippet is:
-
The first version uses
parseInt(value)to convert the string "value" into a number. -
The second version does not use this conversion method; it directly checks whether the input value is less than zero.
The implementation details should be optimized based on specific requirements or best practices:
- If the function receives negative numbers, make sure it handles them correctly;
- Consider adding comments to explain what each part of the script actually does. This will help with future reading and understanding;
Since there doesn't seem to be a significant flaw in logic or structure that would necessitate an optimization here, no further changes beyond these clarifications would significantly benefit the current setup unless more context was provided about the exact conditions under which the functions might need such adjustments.
|
fix: Job create cannot be saved without setting interval