Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using MiniZincSet from JuMP #82

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Allow using MiniZincSet from JuMP #82

merged 7 commits into from
Sep 2, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented Sep 2, 2024

Note that I had to create dummy variable equal to a constant in order to fit in MiniZincSet in the packing example. We could add support to specify that some entries are constant to work around it. It can be a follow-up PR though, no need to complicate this one.

I'm planning to use this packing example on my tutorial on Wednesday.
I can use the development version of the package for that part if it's not merged, no rush.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (7484893) to head (69c73a0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   97.78%   98.40%   +0.61%     
==========================================
  Files           3        3              
  Lines         496      500       +4     
==========================================
+ Hits          485      492       +7     
+ Misses         11        8       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/examples/packing.jl Outdated Show resolved Hide resolved
@odow odow merged commit e359b29 into master Sep 2, 2024
7 checks passed
@odow odow deleted the bl/minizincset branch September 2, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants