Add new attribute NodeLimit #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this also makes for a clean deterministic limit if one wants to solve a MIP up to the root node only (e.g. to get a dual bound from a tightened LP and solutions from a bunch of heuristics) |
blegat
reviewed
Oct 8, 2024
blegat
reviewed
Oct 8, 2024
|
|
||
| ## Default values | ||
|
|
||
| The provided limit must be a `Union{Nothing,Int}`. |
There was a problem hiding this comment.
What about problems with more than typemax(Int32) nodes solved on 32-bit machines 😆
There was a problem hiding this comment.
it's the same issue for many other attributes no?
There was a problem hiding this comment.
I don't think it's common to explore more than 2_147_483_647 nodes on a 32-bit machine 😄
Co-authored-by: Benoît Legat <[email protected]>
odow
reviewed
Oct 8, 2024
odow
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a node limit attribute, which seems to make sense given that there is the corresponding termination status. Most MIP solvers have a limit on the number of nodes in the BNB tree. Note that this is in general different from the number of solved LPs, since each node contains its own solve-and-cut loop (at least for SCIP)