Skip to content

Commit a95bf1a

Browse files
committed
Fix a silly mistake with z-1 instead of 1-z
1 parent 36a0ff4 commit a95bf1a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/Bridges/Constraint/bridges/count_distinct.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ which is equivalent to (for suitable `M`):
5555
\\begin{aligned}
5656
z \\in \\{0, 1\\} \\\\
5757
x - y - M * z <= -1 \\\\
58-
y - x - M * (z - 1) <= -1
58+
y - x - M * (1 - z) <= -1
5959
\\end{aligned}
6060
```
6161
@@ -310,7 +310,7 @@ function _final_touch_not_equal_case(
310310
# <-->
311311
# {x - y <= -1} \/ {y - x <= -1}
312312
# <-->
313-
# {x - y - M * z <= -1} /\ {y - x - M * (z - 1) <= -1}, z in {0, 1}
313+
# {x - y - M * z <= -1} /\ {y - x - M * (1 - z) <= -1}, z in {0, 1}
314314
z, _ = MOI.add_constrained_variable(model, MOI.ZeroOne())
315315
push!(bridge.variables, z)
316316
x, y = scalars[2], scalars[3]
@@ -327,15 +327,15 @@ function _final_touch_not_equal_case(
327327
allow_modify_function = true,
328328
),
329329
)
330-
# {y - x - M * (z - 1) <= -1}, M = u_x - l_y + 1
330+
# {y - x - M * (1 - z) <= -1}, M = u_x - l_y + 1
331331
M = by[2] - bx[1] + 1
332332
g = MOI.Utilities.operate(-, T, y, x)
333333
push!(
334334
bridge.less_than,
335335
MOI.Utilities.normalize_and_add_constraint(
336336
model,
337-
MOI.Utilities.operate!(-, T, g, M * z),
338-
MOI.LessThan(T(-1 - M));
337+
MOI.Utilities.operate!(+, T, g, M * z),
338+
MOI.LessThan(T(-1 + M));
339339
allow_modify_function = true,
340340
),
341341
)

test/Bridges/Constraint/count_distinct.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ function test_runtests_VectorOfVariables_NotEqualTo()
7575
"""
7676
variables: n, x, y, z
7777
1.0 * x + -1.0 * y + -3.0 * z <= -1.0
78-
1.0 * y + -1.0 * x + -5.0 * z <= -6.0
78+
1.0 * y + -1.0 * x + 5.0 * z <= 4.0
7979
x in Interval(1.0, 4.0)
8080
y >= 2.0
8181
y <= 5.0

0 commit comments

Comments
 (0)