Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
odow authored Feb 3, 2024
1 parent b3f8bbf commit 36a0ff4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Bridges/Constraint/bridges/count_distinct.jl
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ function _final_touch_not_equal_case(
push!(bridge.variables, z)
x, y = scalars[2], scalars[3]
bx, by = bridge.bounds[1], bridge.bounds[2]

Check warning on line 317 in src/Bridges/Constraint/bridges/count_distinct.jl

View check run for this annotation

Codecov / codecov/patch

src/Bridges/Constraint/bridges/count_distinct.jl#L314-L317

Added lines #L314 - L317 were not covered by tests
# {x - y - M * z <= -1}, M = u_x - l_y
# {x - y - M * z <= -1}, M = u_x - l_y + 1
M = bx[2] - by[1] + 1
f = MOI.Utilities.operate(-, T, x, y)
push!(

Check warning on line 321 in src/Bridges/Constraint/bridges/count_distinct.jl

View check run for this annotation

Codecov / codecov/patch

src/Bridges/Constraint/bridges/count_distinct.jl#L319-L321

Added lines #L319 - L321 were not covered by tests
Expand All @@ -327,7 +327,7 @@ function _final_touch_not_equal_case(
allow_modify_function = true,
),
)
# {y - x - M * (z - 1) <= -1}, M = u_x - l_y
# {y - x - M * (z - 1) <= -1}, M = u_x - l_y + 1
M = by[2] - bx[1] + 1
g = MOI.Utilities.operate(-, T, y, x)
push!(

Check warning on line 333 in src/Bridges/Constraint/bridges/count_distinct.jl

View check run for this annotation

Codecov / codecov/patch

src/Bridges/Constraint/bridges/count_distinct.jl#L331-L333

Added lines #L331 - L333 were not covered by tests
Expand Down

0 comments on commit 36a0ff4

Please sign in to comment.