-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dims argument to LogSumExpAtom #692
Conversation
So perhaps the simplest thing is just if we add a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 98.20% 98.21% +0.01%
==========================================
Files 89 89
Lines 5168 5198 +30
==========================================
+ Hits 5075 5105 +30
Misses 93 93 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, nice and simple. I think it would be worth carrying over the tests in src/problem_depot/problems/exp.jl from the other PR
Closes #682
Closes #685