-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lieb_ando
: use partially specified problem to get correct vexity
#684
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
=======================================
Coverage 98.19% 98.20%
=======================================
Files 89 89
Lines 5162 5168 +6
=======================================
+ Hits 5069 5075 +6
Misses 93 93 ☔ View full report in Codecov by Sentry. |
unexpected/unrelated docs failure: ERROR: LoadError: LoadError: ArgumentError: Package TimeZones does not have RecipesBase in its dependencies:
- If you have TimeZones checked out for development and have
added RecipesBase as a dependency but haven't updated your primary
environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with TimeZones |
I just restarted it. The TimeZones release is only 2 hours old: https://github.com/JuliaTime/TimeZones.jl/releases/tag/v1.16.0, so I wonder if it's an issue with the cache |
Ha. I just arrived at JuliaTime/TimeZones.jl#459 (comment) to find you there too. As a work-around, we can update the docs to build on Julia 1.10 |
yeah, that works. I put up a patch also: JuliaTime/TimeZones.jl#461 |
This is in fact the approach used in CVXQUAD (https://github.com/hfawzi/cvxquad/blob/master/lieb_ando.m), but we didn't have those yet at the time.
This way we don't have to create an atom! Pretty convenient.
Also: I noticed in many of the CVXQUAD-derived atoms, we expect some variables to be PSD, but don't check or enforce it. Could be something we might want to do.
closes #683