Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formulation of Convex.sumsquares #678

Merged
merged 6 commits into from
May 20, 2024
Merged

Fix formulation of Convex.sumsquares #678

merged 6 commits into from
May 20, 2024

Conversation

odow
Copy link
Member

@odow odow commented May 20, 2024

Closes #677

@ericphanson
Copy link
Collaborator

#679 is an alternative to 639cc28 fyi

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (ecc91cd) to head (29e51a5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #678   +/-   ##
=======================================
  Coverage   98.11%   98.12%           
=======================================
  Files          89       89           
  Lines        5159     5166    +7     
=======================================
+ Hits         5062     5069    +7     
  Misses         97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericphanson ericphanson mentioned this pull request May 20, 2024
@odow odow merged commit 2978c32 into master May 20, 2024
10 checks passed
@odow odow deleted the od/sumsquares branch May 20, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

sumsquares makes both a SOC and RSOC constraint
2 participants