Fix ambiguities found by Aqua #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 97.86% 97.87%
=======================================
Files 88 88
Lines 5116 5120 +4
=======================================
+ Hits 5007 5011 +4
Misses 109 109 ☔ View full report in Codecov by Sentry. |
ericphanson
reviewed
May 9, 2024
| @@ -127,3 +127,7 @@ function Base.getindex(x::VcatAtom, inds::AbstractVector{<:Real}) | |||
| remaining = VcatAtom(keep_children...) | |||
| return IndexAtom(remaining, inds) | |||
| end | |||
|
|
|||
| function Base.getindex(x::VcatAtom, inds::AbstractVector{Bool}) | |||
| return getindex(x, first.(filter!(last, collect(enumerate(inds))))) | |||
There was a problem hiding this comment.
I think this is just findall btw
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #639