Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daraja DI using KOIN #61

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions buildSrc/src/main/kotlin/Dependencies.kt
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ object Versions {
// DI - Dagger
const val dagger = "2.14.1"

//DI-KOIN
const val koin = "2.2.3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we migrate to KOIN V3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we migrate to KOIN V3?

Yes. I'll bump it up.


// Logging - debug builds
const val timber = "4.7.1"
const val leakCanary = "2.4"
Expand Down Expand Up @@ -95,6 +98,10 @@ object Libraries {
const val processor = "com.google.dagger:dagger-android-processor:${Versions.dagger}"
const val daggerCompiler = "com.google.dagger:dagger-compiler:${Versions.dagger}"

//DI - KOIN
const val koin = "io.insert-koin:koin-android:${Versions.koin}"
const val koinViewModel = "io.insert-koin:koin-android-viewmodel:${Versions.koin}"

// Debug - for debug builds only
const val timber = "com.jakewharton.timber:timber:${Versions.timber}"
const val leakCanary = "com.squareup.leakcanary:leakcanary-android:${Versions.leakCanary}"
Expand Down
4 changes: 4 additions & 0 deletions daraja/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ dependencies {
debugImplementation(Libraries.chunkerDebug)
releaseImplementation(Libraries.chunkerRelease)

//DI-KOIN
implementation(Libraries.koin)
implementation(Libraries.koinViewModel)

// debug
implementation(Libraries.timber)

Expand Down