fix: Changed how the tcp connection resolves

juliuscc · May 4, 2019 · f850f84 · f850f84
1 parent 00f8cd4
commit f850f84
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/__mocks__/net.ts b/__mocks__/net.ts
@@ -33,8 +33,8 @@ export function __setOn(newOn: any) {
 	on = newOn
 }
 
-export function createConnection(_port: number, _host: string) {
-	return { write: () => {}, on }
+export function createConnection(_options: object, callback: Function) {
+	callback({ write: () => {}, on })
 }
 
 const net = { createConnection, __setOn, __setOnData, __setOnError }

diff --git a/src/connection/connect.ts b/src/connection/connect.ts
@@ -15,13 +15,13 @@ function createHeosSocket(address: string, responseParser: ResponseParser): Prom
 		const port: number = DEFAULT_PORT
 
 		try {
-			const socket: Socket = createConnection(port, host)
+			const socket: Socket = createConnection({ port, host }, () => {
+				resolve(socket)
+			})
 
 			socket.on('data', (data: string) => responseParser.put(data))
-
 			socket.on('timeout', reject)
-
-			resolve(socket)
+			socket.on('error', reject)
 		} catch (error) {
 			reject(error)
 		}