Skip to content

Upgrade Aero to the latest version #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2019

Conversation

akyoto
Copy link
Contributor

@akyoto akyoto commented Nov 14, 2019

I was curious to see how it would perform with the latest performance improvements and the numbers are vastly different with v1.3.41 (much better).

About 20-25% better routing performance and 80% less memory usage.

This PR aims to be minimal and only update go.mod and go.sum for aerogo/aero.

@akyoto
Copy link
Contributor Author

akyoto commented Nov 16, 2019

After stumbling upon this comment about Iris I am no longer sure if the use of separate code paths for static routes and dynamic routes is accepted in your benchmark.

Likewise, I am using sync.Pool for contexts which you - rightfully - criticized, because it's not really 0B.

If the implications of these decisions are unacceptable for your benchmark suite, please let me know.

@julienschmidt julienschmidt merged commit 250364b into julienschmidt:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants