Skip to content

Commit

Permalink
ConverterCommandTest to Pest style
Browse files Browse the repository at this point in the history
  • Loading branch information
@julien-boudry
julien-boudry committed May 27, 2024
1 parent 452965b commit 109829a
Show file tree
Hide file tree
Showing 3 changed files with 99 additions and 112 deletions.
1 change: 1 addition & 0 deletions tests/Pest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

uses(Tests\CondorcetTestCase::class);
uses(Tests\AlgoTestCase::class)->in('src/Algo');
uses(Tests\src\Console\ConsoleTestCase::class)->in('src/Console');
uses(Tests\src\Tools\Randomizers\RandomizerTestCase::class)->in('src/Tools/Randomizers');


Expand Down
196 changes: 84 additions & 112 deletions tests/src/Console/Commands/ConverterCommandTest.php
View file
Original file line number Diff line number Diff line change
@@ -1,120 +1,92 @@
<?php

declare(strict_types=1);

namespace CondorcetPHP\Condorcet\Tests\Console\Commands;

use PHPUnit\Framework\TestCase;
use CondorcetPHP\Condorcet\Console\CondorcetApplication;
use CondorcetPHP\Condorcet\Throwable\ConsoleInputException;
use CondorcetPHP\Condorcet\Throwable\Internal\CondorcetInternalException;
use PHPUnit\Framework\Attributes\DataProvider;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Tester\CommandTester;

class ConverterCommandTest extends TestCase
{
public const DEBIAN_INPUT_FILE = __DIR__ . '/../../Tools/Converters/DebianData/leader2020_tally.txt';
public const DAVIDHILL_INPUT_FILE = __DIR__ . '/../../Tools/Converters/TidemanData/A77.HIL';

public const OUTPUT_FILE = __DIR__ . '/files/out.temp';

private readonly CommandTester $converterCommand;

protected function setUp(): void
{
CondorcetApplication::create();

$this->converterCommand = new CommandTester(CondorcetApplication::$SymfonyConsoleApplication->find('convert'));
}

protected function tearDown(): void
{
file_exists(self::OUTPUT_FILE) && unlink(self::OUTPUT_FILE);
}

public static function conversionsProvider(): array
{
return [
'fromDebianToCondorcet' => ['--from-debian-format', '--to-condorcet-election-format', self::DEBIAN_INPUT_FILE, __DIR__ . '/files/fromDebianExpectedFile.cvotes'],
'fromDavidHillToCondorcet' => ['--from-david-hill-format', '--to-condorcet-election-format', self::DAVIDHILL_INPUT_FILE, __DIR__ . '/files/fromDavidHillExpectedFile.cvotes'],
];
}

#[DataProvider('conversionsProvider')]
public function testSuccessfullConversions(string $from, string $to, string $input, string $comparaison): void
{
$this->converterCommand->execute(
[
$from => true,
$to => true,
'input' => $input,
'output' => self::OUTPUT_FILE,
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);

$output = $this->converterCommand->getDisplay();
$this->converterCommand->assertCommandIsSuccessful();
expect($this->converterCommand->getStatusCode())->toBe(0);
expect($output)->toBeEmpty();

expect(file_get_contents(self::OUTPUT_FILE))->toBe(file_get_contents($comparaison));
}

public function testLacksAnOption(): void
{
$this->expectException(ConsoleInputException::class);
$this->expectExceptionMessageMatches('/output/');

$this->converterCommand->execute(
[
'--from-debian-format' => true,
// Missing option
'input' => self::DEBIAN_INPUT_FILE,
'output' => self::OUTPUT_FILE,
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);
}

public function testLacksAnArgument(): void
{
$this->expectException(ConsoleInputException::class);
$this->expectExceptionMessageMatches('/output/');

$this->converterCommand->execute(
[
'--from-debian-format' => true,
'--to-condorcet-election-format' => true,
'input' => self::DEBIAN_INPUT_FILE,
// Missing
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);
}

public function testWrongInput(): void
{
$this->expectException(CondorcetInternalException::class);
$this->expectExceptionMessage('The input file does not exist');

$this->converterCommand->execute(
[
'--from-debian-format' => true,
'--to-condorcet-election-format' => true,
'input' => '42.txt',
// Missing
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);
}
}
use Tests\src\Console\ConsoleTestCase;

beforeEach(function () {
CondorcetApplication::create();

$this->converterCommand = new CommandTester(CondorcetApplication::$SymfonyConsoleApplication->find('convert'));
});
afterEach(function () {
file_exists(self::OUTPUT_FILE) && unlink(self::OUTPUT_FILE);
});
dataset('conversionsProvider', function () {
return [
'fromDebianToCondorcet' => ['--from-debian-format', '--to-condorcet-election-format', ConsoleTestCase::DEBIAN_INPUT_FILE, __DIR__ . '/files/fromDebianExpectedFile.cvotes'],
'fromDavidHillToCondorcet' => ['--from-david-hill-format', '--to-condorcet-election-format', ConsoleTestCase::DAVIDHILL_INPUT_FILE, __DIR__ . '/files/fromDavidHillExpectedFile.cvotes'],
];
});
test('successfull conversions', function (string $from, string $to, string $input, string $comparaison) {
$this->converterCommand->execute(
[
$from => true,
$to => true,
'input' => $input,
'output' => self::OUTPUT_FILE,
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);

$output = $this->converterCommand->getDisplay();
$this->converterCommand->assertCommandIsSuccessful();
expect($this->converterCommand->getStatusCode())->toBe(0);
expect($output)->toBeEmpty();

expect(file_get_contents(self::OUTPUT_FILE))->toBe(file_get_contents($comparaison));
})->with('conversionsProvider');
test('lacks an option', function () {
$this->expectException(ConsoleInputException::class);
$this->expectExceptionMessageMatches('/output/');

$this->converterCommand->execute(
[
'--from-debian-format' => true,
// Missing option
'input' => self::DEBIAN_INPUT_FILE,
'output' => self::OUTPUT_FILE,
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);
});
test('lacks an argument', function () {
$this->expectException(ConsoleInputException::class);
$this->expectExceptionMessageMatches('/output/');

$this->converterCommand->execute(
[
'--from-debian-format' => true,
'--to-condorcet-election-format' => true,
'input' => self::DEBIAN_INPUT_FILE,
// Missing
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);
});
test('wrong input', function () {
$this->expectException(CondorcetInternalException::class);
$this->expectExceptionMessage('The input file does not exist');

$this->converterCommand->execute(
[
'--from-debian-format' => true,
'--to-condorcet-election-format' => true,
'input' => '42.txt',
// Missing
],
[
'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
]
);
});
14 changes: 14 additions & 0 deletions tests/src/Console/ConsoleTestCase.php
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

declare(strict_types=1);

namespace Tests\src\Console;

use Tests\CondorcetTestCase;

class ConsoleTestCase extends CondorcetTestCase
{
public const DEBIAN_INPUT_FILE = __DIR__ . '/../Tools/Converters/DebianData/leader2020_tally.txt';
public const DAVIDHILL_INPUT_FILE = __DIR__ . '/../Tools/Converters/TidemanData/A77.HIL';
public const OUTPUT_FILE = __DIR__ . '/Commands/files/out.temp';
}

0 comments on commit 109829a

Please sign in to comment.