Enable asymmetric y-axes via user-input parameter to ggmiami or prep_miami_data and improve plot alignment
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow prepping data to permit future plots with separate y-axis scales in cases for which symmetry is not a desirable feature
Uses `grid` package as explicit dependency
|
Adding a commit to improve upper/lower chart alignment as detailed here: #6. Uses secondary, more general solution from here: https://stackoverflow.com/questions/13294952/left-align-two-graph-edges-ggplot |
jlandman
changed the title
ggmiami or prep_miami_dataggmiami or prep_miami_data and improves plot alignment
jlandman
changed the title
ggmiami or prep_miami_data and improves plot alignmentggmiami or prep_miami_data and improve plot alignment
|
Fixing some unanticipated bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter to both
prep_miami_dataandggmiamito enable split y-axis scales as needed for users to whom such use cases are valuable (like me!).Note: this PR does not fix axis limits when suggestive lines and genome lines exceed the axis limits established by maximum logged p-values, but that will be forthcoming in a future PR should someone else not get to it first.
Fixes issue #5.