FF8: Bring back shadows and tinted window #750
Merged
+49
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myst6re
force-pushed
the
fix/693-substractive-blending
branch
5 times, most recently
from
b93b180
to
f8494bf
Compare
myst6re
force-pushed
the
fix/693-substractive-blending
branch
from
f8494bf
to
9eabb75
Compare
julianxhokaxhiu
approved these changes
Nov 16, 2024
julianxhokaxhiu
added
bug
julianxhokaxhiu
changed the title
|
Spectacular PR, well done :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #693 and more
Bring back shadows and tinted window
Elevator window is darker
Shadows are back
Battle transition + shadows
https://github.com/user-attachments/assets/674a7e17-cfd7-48ae-b84d-d32bb228cd5a
Field transition
https://github.com/user-attachments/assets/f26643be-1462-439a-bd11-076ec4b18471
Motivation
Substractive blending is enabled only if the graphic driver is software and use paletted textures.
Regression
Unfortunately Battle transition (from worldmap at least) suffer from this change
ACKs