ci: migrate to new coverage and quality actions #1332
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
| cache: true | ||
| # TODO: move the code to the new tall style once Flutter 3.29 is the new minimum. | ||
| # https://github.com/juliansteenbakker/mobile_scanner/issues/1326 | ||
| flutter-version: '3.27' |
There was a problem hiding this comment.
I think it is safe to remove this in the new actions, because it does not make any changes testing to 3.27 or the current 3.29. What do you think @navaronbracke
There was a problem hiding this comment.
I'm fine with that, we will need to commit a dart format . pass with the new style, though.
There was a problem hiding this comment.
dart format . will not change until we change the sdk constraint to 3.7.0 or higher, so it's only something to look after when upgrading the constraint.
environment:
sdk: ">=3.6.0 <4.0.0"
There was a problem hiding this comment.
Right, sorry, I keep forgetting that this is tied to the minimum language version :p
|
@juliansteenbakker It's good to see code coverage being enabled. However, since we do not have many tests currently, how will this work? It picks the current develop branch as baseline and the "number has to go up" ? |
Exactly. It will give insight into what is tested and what not, so it will be an incentive for new PRs to also write tests if possible. It does not matter that the number will be low right now. |
|
@navaronbracke i saw a comment of you that you've deleted about the dart code width. I would love to make it bigger than the default 80 characters, however, i think its good to wait a little bit and see if there is any new standard size coming up. I can see certain linters like very_good_analysis adapting something like a default "wide view". Until then, i think its best to stick with the default 80 characters for now. |
|
The |
|
Of course that's also a requirement 😃 |
No description provided.