fix: turn off camerax info logs #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Feb 13, 2025
| // This prevents the informational log spam from CameraX. | ||
| private fun configureCameraProcessProvider() { | ||
| try { | ||
| val config = CameraXConfig.Builder.fromConfig(Camera2Config.defaultConfig()).apply { |
There was a problem hiding this comment.
This uses the default Camera2 config and extends it with the override for logging level.
Per the docs in https://developer.android.com/reference/androidx/camera/lifecycle/ProcessCameraProvider#configureInstance(androidx.camera.core.CameraXConfig)
we can only do this once, though, since it is a singleton.
navaronbracke
commented
Feb 13, 2025
| @@ -42,7 +45,6 @@ import dev.steenbakker.mobile_scanner.utils.serialize | |||
| import io.flutter.view.TextureRegistry | |||
| import kotlinx.coroutines.CoroutineScope | |||
| import kotlinx.coroutines.Dispatchers | |||
| import kotlinx.coroutines.coroutineScope | |||
There was a problem hiding this comment.
Unused import
navaronbracke
commented
Feb 13, 2025
| @@ -55,5 +55,8 @@ jobs: | |||
| - uses: subosito/flutter-action@v2 | |||
| with: | |||
| cache: true | |||
| # TODO: move the code to the new tall style once Flutter 3.29 is the new minimum. | |||
There was a problem hiding this comment.
The formatting action is using the latest stable Flutter version, 3.29.0.
That opts us into Dart 3.7 which includes new tall-style formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns off the CameraX logging for the
Log.DEBUG,Log.INFOandLog.WARNlogging.Per the docs of CameraX:
We could technically also allow
Log.WARN, but I'm not sure if that is going to help much.Fixes #1255