Update Avro version to 1.12.0 #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianpeeters
commented
Aug 6, 2024
There was a problem hiding this comment.
In addition to the classLoader issue below, the scripted tests in sbt-avrohugger are also failing due to an issue with the parser.
| @@ -89,8 +97,8 @@ class FileInputParser { | |||
| val protocol = Protocol.parse(infile) | |||
| List(Right(protocol)) | |||
| case "avdl" => | |||
| val idlParser = new Idl(infile, classLoader) | |||
| val protocol = idlParser.CompilationUnit() | |||
| val idl = new IdlReader().parse(infile.toPath()) | |||
There was a problem hiding this comment.
we need a parse method that accepts our classLoader, as was available for the Idl constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Avro 1.12.0 deprecates
Idlin favor of the newIdlReader.Test Status