-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: adds plugin interface, webdriver support #17
base: master
Are you sure you want to change the base?
Conversation
@ptsteadman who is assisting |
This is very interesting! I actually thought about doing something similar just recently. We definitely need to move away from PhantomJS. I wrote a couple of modules in preparation already too:
Those use command line interfaces instead of Webdriver. I wasn't sure about using it, do you see any strong points in favor of Webdriver? I'll collect my thoughts on this PR in another comment, don't think I forgot about it. |
About the missing |
Hi Julian, I like these capture modules better since they don't require any prerequisite setup or a running selenium server. |
re: |
that's the plan :) i want to overhaul the UI anyways |
awesome - when i get a chance this week i will update this PR (or maybe just make a new one) that:
|
Awesome, thank you so much! |
PhantomJS chokes on a lot of SSL pages I want to monitor so I added a plugin interface and a webdriver plugin.
I think some of my semantics are still slightly off (e.g: currently doing full-page screenshot instead of respecting resolutions) - I will fix these shortly.
Wanted to see if this was something you were interested in.