Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adds plugin interface, webdriver support #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r1b
Copy link

@r1b r1b commented Oct 12, 2017

PhantomJS chokes on a lot of SSL pages I want to monitor so I added a plugin interface and a webdriver plugin.

I think some of my semantics are still slightly off (e.g: currently doing full-page screenshot instead of respecting resolutions) - I will fix these shortly.

Wanted to see if this was something you were interested in.

@r1b
Copy link
Author

r1b commented Oct 12, 2017

@ptsteadman who is assisting

@juliangruber
Copy link
Owner

This is very interesting! I actually thought about doing something similar just recently. We definitely need to move away from PhantomJS.

I wrote a couple of modules in preparation already too:

Those use command line interfaces instead of Webdriver. I wasn't sure about using it, do you see any strong points in favor of Webdriver?

I'll collect my thoughts on this PR in another comment, don't think I forgot about it.

@juliangruber
Copy link
Owner

About the missing cut option, I thought about dropping it anyway in favor of a client side fold overlay. What do you think about that?

@r1b
Copy link
Author

r1b commented Oct 15, 2017

Hi Julian,

I like these capture modules better since they don't require any prerequisite setup or a running selenium server.

@r1b
Copy link
Author

r1b commented Oct 15, 2017

re: cut - client side overlay is fine, it is also easily done as post processing - will you be able to toggle the overlay in the UI?

@juliangruber
Copy link
Owner

re: cut - client side overlay is fine, it is also easily done as post processing - will you be able to toggle the overlay in the UI?

that's the plan :) i want to overhaul the UI anyways

@r1b
Copy link
Author

r1b commented Oct 16, 2017

awesome - when i get a chance this week i will update this PR (or maybe just make a new one) that:

  1. Uses these modules you have created as plugins
  2. Restores your resolution semantics and ensures a full-page screenshot option is available for all plugins

@juliangruber
Copy link
Owner

Awesome, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants