Broken regex implementation

[stevemao]

do you support this use-case?

If the str contains more a than b / there are unmatched pairs, and a and/or b is regex, what's the expected behaviour?

[juliangruber]

i think this should be covered by your other pull requests already, right?

also if you want, i'd be happy to add you as a collaborator on this project

[stevemao]

I don't think this is covered? Which one did you refer to?

Happy to contribute to this anyhow 😄

[juliangruber]

doesn't this cover that?

If the str contains more a than b / there are unmatched pairs, the first match that was closed will be used. For example, {{a} will match ['{', 'a', ''] and {a}} will match ['', 'a', '}'].

[stevemao]

Oh not with a or b as regex. Also that was just a missing test.

BTW just realise you didn't enable travis.

[stevemao]

This is supposed to be a failure test.

[juliangruber]

i enabled travis now, no clue why it was disabled...

[stevemao]

Basically regex only works for very simple use-cases. In order to support all, I think it will be very complicated and performance might be questionable.