Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add limit to getDuration() in spring function to avoid infinite loops #798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okikio
Copy link
Contributor

@okikio okikio commented Jan 17, 2022

The way the getDuration() method in the spring() function is setup it doesn't have any way of stopping an infinite loop. I added a INTINITE_LOOP_LIMIT of 10,000 to stop possible infinite loop situations.

@okikio
Copy link
Contributor Author

okikio commented Jan 17, 2022

After re-looking though the problem I've determined that the issue I had doesn't require an infinite loop limit, I still believe we should apply a loop limit to the getDuration() method, but it's not required for my problem.

If you'd like to see the problem I aiming to fix, here is a Codepen, https://codepen.io/okikio/pen/GRMeapZ?editors=0010

cc @RafaelKr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant