Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add valid svg attributes and allow empty attributes #524

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add valid svg attributes and allow empty attributes #524

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c52617e
Add valid svg attributes and allow empty attributes
ph1p Feb 6, 2019
70cc55a
Merge remote-tracking branch 'github.com/master' into feature/empty-s…
ph1p Jul 24, 2020
59b150c
Remove deprecated and string based svg attributes
ph1p Jul 24, 2020
b94748e
Remove more attributes
ph1p Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
294 changes: 289 additions & 5 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,290 @@ const defaultTweenSettings = {

const validTransforms = ['translateX', 'translateY', 'translateZ', 'rotate', 'rotateX', 'rotateY', 'rotateZ', 'scale', 'scaleX', 'scaleY', 'scaleZ', 'skew', 'skewX', 'skewY', 'perspective'];

const validSvgAttributes = [
'accent-height',
'accumulate',
'additive',
'alignment-baseline',
'allowReorder',
'alphabetic',
'amplitude',
'arabic-form',
'ascent',
'attributeName',
'attributeType',
'autoReverse',
'azimuth',
'BSection',
'baseFrequency',
'baseline-shift',
'baseProfile',
'bbox',
'begin',
'bias',
'by',
'CSection',
'calcMode',
'cap-height',
'class',
'clip',
'clipPathUnits',
'clip-path',
'clip-rule',
'color',
'color-interpolation',
'color-interpolation-filters',
'color-profile',
'color-rendering',
'contentScriptType',
'contentStyleType',
'cursor',
'cx',
'cy',
'DSection',
'd',
'decelerate',
'descent',
'diffuseConstant',
'direction',
'display',
'divisor',
'dominant-baseline',
'dur',
'dx',
'dy',
'ESection',
'edgeMode',
'elevation',
'enable-background',
'end',
'exponent',
'externalResourcesRequired',
'FSection',
'fill',
'fill-opacity',
'fill-rule',
'filter',
'filterRes',
'filterUnits',
'flood-color',
'flood-opacity',
'font-family',
'font-size',
'font-size-adjust',
'font-stretch',
'font-style',
'font-variant',
'font-weight',
'format',
'from',
'fr',
'fx',
'fy',
'GSection',
'g1',
'g2',
'glyph-name',
'glyph-orientation-horizontal',
'glyph-orientation-vertical',
'glyphRef',
'gradientTransform',
'gradientUnits',
'HSection',
'hanging',
'height',
'href',
'hreflang',
'horiz-adv-x',
'horiz-origin-x',
'ISection',
'id',
'ideographic',
'image-rendering',
'in',
'in2',
'intercept',
'KSection',
'k',
'k1',
'k2',
'k3',
'k4',
'kernelMatrix',
'kernelUnitLength',
'kerning',
'keyPoints',
'keySplines',
'keyTimes',
'LSection',
'lang',
'lengthAdjust',
'letter-spacing',
'lighting-color',
'limitingConeAngle',
'local',
'MSection',
'marker-end',
'marker-mid',
'marker-start',
'markerHeight',
'markerUnits',
'markerWidth',
'mask',
'maskContentUnits',
'maskUnits',
'mathematical',
'max',
'media',
'method',
'min',
'mode',
'NSection',
'name',
'numOctaves',
'OSection',
'offset',
'opacity',
'operator',
'order',
'orient',
'orientation',
'origin',
'overflow',
'overline-position',
'overline-thickness',
'PSection',
'panose-1',
'paint-order',
'path',
'pathLength',
'patternContentUnits',
'patternTransform',
'patternUnits',
'ping',
'pointer-events',
'points',
'pointsAtX',
'pointsAtY',
'pointsAtZ',
'preserveAlpha',
'preserveAspectRatio',
'primitiveUnits',
'RSection',
'r',
'radius',
'referrerPolicy',
'refX',
'refY',
'rel',
'rendering-intent',
'repeatCount',
'repeatDur',
'requiredExtensions',
'requiredFeatures',
'restart',
'result',
'rotate',
'rx',
'ry',
'SSection',
'scale',
'seed',
'shape-rendering',
'slope',
'spacing',
'specularConstant',
'specularExponent',
'speed',
'spreadMethod',
'startOffset',
'stdDeviation',
'stemh',
'stemv',
'stitchTiles',
'stop-color',
'stop-opacity',
'strikethrough-position',
'strikethrough-thickness',
'string',
'stroke',
'stroke-dasharray',
'stroke-dashoffset',
'stroke-linecap',
'stroke-linejoin',
'stroke-miterlimit',
'stroke-opacity',
'stroke-width',
'style',
'surfaceScale',
'systemLanguage',
'TSection',
'tabindex',
'tableValues',
'target',
'targetX',
'targetY',
'text-anchor',
'text-decoration',
'text-rendering',
'textLength',
'to',
'transform',
'type',
'USection',
'u1',
'u2',
'underline-position',
'underline-thickness',
'unicode',
'unicode-bidi',
'unicode-range',
'units-per-em',
'VSection',
'v-alphabetic',
'v-hanging',
'v-ideographic',
'v-mathematical',
'values',
'vector-effect',
'version',
'vert-adv-y',
'vert-origin-x',
'vert-origin-y',
'viewBox',
'viewTarget',
'visibility',
'WSection',
'width',
'widths',
'word-spacing',
'writing-mode',
'XSection',
'x',
'x-height',
'x1',
'x2',
'xChannelSelector',
'xlink:actuate',
'xlink:arcrole',
'xlink:href',
'xlink:role',
'xlink:show',
'xlink:title',
'xlink:type',
'xml:base',
'xml:lang',
'xml:space',
'YSection',
'y',
'y1',
'y2',
'yChannelSelector',
'ZSection',
'z',
'zoomAndPan'
];

// Caching

const cache = {
Expand Down Expand Up @@ -126,7 +410,7 @@ function elastic(amplitude = 1, period = .5) {
const a = minMax(amplitude, 1, 10);
const p = minMax(period, .1, 2);
return t => {
return (t === 0 || t === 1) ? t :
return (t === 0 || t === 1) ? t :
-a * Math.pow(2, 10 * (t - 1)) * Math.sin((((t - 1) - (p / (Math.PI * 2) * Math.asin(1 / a))) * (Math.PI * 2)) / p);
}
}
Expand Down Expand Up @@ -262,7 +546,7 @@ const penner = (() => {
]
}

let eases = {
let eases = {
linear: [0.250, 0.250, 0.750, 0.750]
}

Expand Down Expand Up @@ -452,7 +736,7 @@ function getCSSValue(el, prop, unit) {
}

function getAnimationType(el, prop) {
if (is.dom(el) && !is.inp(el) && (getAttribute(el, prop) || (is.svg(el) && el[prop]))) return 'attribute';
if (is.dom(el) && !is.inp(el) && (getAttribute(el, prop) || (is.svg(el) && arrayContains(validSvgAttributes, prop)))) return 'attribute';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good improvement for .set() and animatable values. But you affect some not animatable values like class. Need to add a check for preventing animating such attributes.

if (is.dom(el) && arrayContains(validTransforms, prop)) return 'transform';
if (is.dom(el) && (prop !== 'transform' && getCSSValue(el, prop))) return 'css';
if (el[prop] != null) return 'object';
Expand Down Expand Up @@ -523,7 +807,7 @@ function getRectLength(el) {

function getLineLength(el) {
return getDistance(
{x: getAttribute(el, 'x1'), y: getAttribute(el, 'y1')},
{x: getAttribute(el, 'x1'), y: getAttribute(el, 'y1')},
{x: getAttribute(el, 'x2'), y: getAttribute(el, 'y2')}
);
}
Expand Down Expand Up @@ -858,7 +1142,7 @@ let pausedInstances = [];
let raf;

const engine = (() => {
function play() {
function play() {
raf = requestAnimationFrame(step);
}
function step(t) {
Expand Down