-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JSON serialization interface #92
Implement JSON serialization interface #92
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage ? 90.59%
=======================================
Files ? 5
Lines ? 287
Branches ? 0
=======================================
Hits ? 260
Misses ? 27
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I really like this! Could you maybe add some tests? But I will certainly merge this. |
I thought about additional tests but I faced 2 problems
|
@davidanthoff Any ideas as to what tests could be added on your side ? I would gladly close this ASAP. |
I just added tests to this PR here. I also changed the implementation slightly, I think the original version essentially had some type piracy issues. Can you take a look over this version, whether that works for you? If tests pass, I'll merge. |
@davidanthoff In a sense there was a bit of type piracy, in the sense that I defined
instead of a
i'm fine with your implementation if you are. Do you plan to move to JSON3 at some point ? Also, do you plan to release a version with this ? |
Fixes #89
No addition for Julia VS Code extension.
Has to be non-breaking, otherwise this is a bug.