-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agents-api,memory-store): Tasks queries #978
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
CI Failure Feedback 🧐(Checks updated until commit b8cf8ce)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to b8cf8ce in 1 minute and 18 seconds
More details
- Looked at
3028
lines of code in42
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_4EwwntLjJnlK5R6A
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -238,6 +245,10 @@ def _return_data(rec: list[Record]): | |||
return obj | |||
|
|||
objs: list[ModelT] = [cls(**item) for item in map(transform, data)] | |||
print("data", data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using print
statements for debugging in production code. Consider using a logging framework instead.
@@ -238,6 +245,10 @@ | |||
return obj | |||
|
|||
objs: list[ModelT] = [cls(**item) for item in map(transform, data)] | |||
print("data", data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this print
statement to keep the code clean.
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
PR Type
Enhancement
Description
Changes walkthrough 📝
Tasks.py
Add canonical name and field validation to Task models
agents-api/agents_api/autogen/Tasks.py
models
Add task management queries and version control
agents-api/agents_api/queries/tasks/
000010_tasks.up.sql
Add tasks and workflows database schema
memory-store/migrations/000010_tasks.up.sql