Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Grafana dashboards and set temporal metrics port statically #945

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

whiterabbit1983
Copy link
Contributor

@whiterabbit1983 whiterabbit1983 commented Dec 11, 2024

Important

Fixes Grafana dashboard provisioning and sets Temporal metrics port statically in Docker Compose configurations.

  • Grafana Dashboard Fixes:
    • Added volume mappings in monitoring/docker-compose.yml for Grafana dashboards.
    • Created monitoring/grafana/dashboard.yaml to configure dashboard provisioning.
  • Temporal Metrics Port:
    • Set PROMETHEUS_ENDPOINT to 0.0.0.0:15000 in scheduler/docker-compose.yml for static port assignment.

This description was created by Ellipsis for a5f3f7d. It will automatically update as commits are pushed.

Copy link
Contributor

@standard-input standard-input bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues flagged.
Standard Input can make mistakes. Check important info.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to a5f3f7d in 32 seconds

More details
  • Looked at 46 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_rkMy2szcpLPxanT0


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

scheduler/docker-compose.yml Show resolved Hide resolved
@whiterabbit1983 whiterabbit1983 merged commit bf48324 into dev Dec 11, 2024
6 checks passed
@whiterabbit1983 whiterabbit1983 deleted the x/grafana-dashboard branch December 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant