Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove indices which are not defined for a given set of fields #944

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

whiterabbit1983
Copy link
Contributor

@whiterabbit1983 whiterabbit1983 commented Dec 10, 2024

Important

Remove specific index references from queries across multiple files to handle undefined indices.

  • Behavior:
    • Removed index references from queries in search_docs_by_embedding.py, search_docs_by_text.py, and get_execution.py.
    • Removed index references from queries in get_paused_execution_token.py, list_execution_transitions.py, and update_execution.py.
    • Removed index references from queries in get_task.py, get_user.py, and list_users.py.
  • Queries:
    • Removed :owner_id_metadata_doc_id_idx from search_docs_by_embedding.py and search_docs_by_text.py.
    • Removed :execution_id_status_idx from get_execution.py and get_paused_execution_token.py.
    • Removed :execution_id_type_created_at_idx from list_execution_transitions.py.
    • Removed :task_id_agent_id_idx from get_task.py.
    • Removed :developer_id_metadata_user_id_idx from get_user.py and list_users.py.

This description was created by Ellipsis for ba39f2a. It will automatically update as commits are pushed.

@whiterabbit1983 whiterabbit1983 marked this pull request as ready for review December 10, 2024 14:40
@whiterabbit1983 whiterabbit1983 merged commit 83487c3 into dev Dec 10, 2024
14 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/cozo-indices branch December 10, 2024 14:40
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ba39f2a in 13 seconds

More details
  • Looked at 125 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/models/docs/search_docs_by_embedding.py:94
  • Draft comment:
    The removal of the index owner_id_metadata_doc_id_idx from the query might affect performance if the index was used for optimization. Ensure that the query performance is acceptable without the index. This comment applies to other similar changes in the PR.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes indices from queries, which seems to be intentional to simplify or correct the queries. However, the PR description is missing, so I need to ensure that the removal of indices does not affect the functionality or performance negatively.

Workflow ID: wflow_DfW2EnvBc25Aw3Km


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant