Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start using self-hosted runners #572

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

hmlanigan
Copy link
Member

@hmlanigan hmlanigan commented Sep 11, 2024

Description

Try using the Canonical self-hosted runners available. The juju runners required setup which was never changed as they were running noble.

While using the runners, a new error appeared in TestProviderConfigureAddresses where the wording of the error changed. Updated the test to handle both cases.

Additional Information

JUJU-6829

@hmlanigan
Copy link
Member Author

The 3.1 microk8s tests are failing due to additional time, perhaps related to the charm used for resource oci-image-url changes. This needs to be investigated, but not part of this PR. https://warthogs.atlassian.net/browse/JUJU-6834

Copy link
Contributor

@Aflynn50 Aflynn50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though in the PR description, you say that we are using the self hosted runners as available. Does that mean we should fall back on the hosted runners if they are not? If so, I don't the mechanism for that in this PR

@hmlanigan
Copy link
Member Author

Looks fine, though in the PR description, you say that we are using the self hosted runners as available. Does that mean we should fall back on the hosted runners if they are not? If so, I don't the mechanism for that in this PR

I removed that phrase. We're using the PS runners with no fall back.

@kian99
Copy link
Contributor

kian99 commented Sep 27, 2024

We need to update the jaas integration test file too now.

Try using the Canonical self-hosted runners available as they are
available. The juju runners required setup which was never changed as
they were running noble. Specifying jammy to help ensure we do not
use the juju aws runners.

Fix add machine test action, failed as the go version was not specified.
Check the error details, the error summary changes based on different
runners. Sometimes expected: "i/o timeout" vs "connect: connection refused"
Used to build the docs from schemas. Not all runners have terraform
installed, ensure it is available.
@hmlanigan
Copy link
Member Author

@kian99 thank you for the reminder

Copy link
Contributor

@Aflynn50 Aflynn50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good

@hmlanigan
Copy link
Member Author

/merge

@jujubot jujubot merged commit 5924142 into juju:main Oct 1, 2024
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants