This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
snap support #1
Open
snap support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets make sure that we squash these commits, when appropriate |
wwwtyro
force-pushed
the
rye/snaps
branch
6 times, most recently
from
b349631 to
c24039e
Compare
This is necessary for kube-controller-manager to provision volumes with `rbd`.
* support multiple platforms * allow multiple architectures with a single invocation of make
|
LGTM. Let me know if we want this merged or not. |
* include conntrack bin in the kube-proxy snap * add path to conntrack bin in the kube-proxy snap
* Stop building kubefed * Adding kubefed.yaml back
In order to pass env vars to the daemons in a generic fashion, this sources the /root/cdk/kube.env file if it exists.
We need to be able to build snaps with a suffix. These are identical to our normal snap builds, but allow us to have a variation in the store, like 'kubectl-foo'. This makes it possible to keep variants on different versions without having a bunch of channels muddying up the primary 'kubectl' snap.
…-controller-manager (#25)
This makes sure snaps can still be built on bionic hosts. Signed-off-by: Adam Stokes <[email protected]>
* Fix docker builds This updates to a recent stable container for building snaps via docker. Signed-off-by: Adam Stokes <[email protected]> * Include file in container, link magic db Signed-off-by: Adam Stokes <[email protected]>
Signed-off-by: Adam Stokes <[email protected]>
@battlemidget Looks like somewhere along the way we lost the ability to pass KUBE_VERSION and KUBE_ARCH through to the build script. It just always builds the latest stable Kubernetes (currently v1.11.3). This PR should fix it. I also moved the docker-build.sh script into build-scripts/ to tidy up a bit, hope that's cool.
Run with: cd release/snap KUBE_ARCH=amd64 KUBE_VERSION=v1.11.3 ./build-scripts/docker-build kubectl Signed-off-by: Adam Stokes <[email protected]>
* Add support for ppc64, arm64, s390x Signed-off-by: Adam Stokes <[email protected]> * add make to aarch64 dockerfile Signed-off-by: Adam Stokes <[email protected]>
adam-stokes
force-pushed
the
rye/snaps
branch
2 times, most recently
from
11465b2 to
29615e9
Compare
Signed-off-by: Adam Stokes <[email protected]>
adam-stokes
force-pushed
the
rye/snaps
branch
from
29615e9 to
9d7566a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.