Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS Guide #31

Merged
merged 6 commits into from
Jan 18, 2020
Merged

Added AWS Guide #31

merged 6 commits into from
Jan 18, 2020

Conversation

orangecola
Copy link
Contributor

@orangecola orangecola commented Jan 10, 2020 •
edited
Loading

Fixes issue #15

Do note that links won't work until the repo has been merged.

I could rewrite the eksctl cluster to use a config file too, would you be interested in that?

@orangecola
AWS Guide
b742f07 
Added a declarative kubectl and eksctl config to make installation easier
Edited AWS Guide
Edited aws-ingress.yaml to set the load balancer connect to pods directly
@J12934
Copy link
Member

J12934 commented Jan 10, 2020

Nice looks good 👍

I could rewrite the eksctl cluster to use a config file too, would you be interested in that?

What's that config file for? To replace the cli flags in the eksctl create cluster command?

@J12934 J12934 added the documentation Improvements or additions to documentation label Jan 10, 2020
@J12934
Copy link
Member

J12934 commented Jan 10, 2020

I'll try it out over the weekend. If it works nicely we might be able to remove the WIP flag 😉

@orangecola
Copy link
Contributor Author

orangecola commented Jan 10, 2020 via email

@orangecola
Copy link
Contributor Author

orangecola commented Jan 10, 2020 via email

@J12934
Copy link
Member

J12934 commented Jan 10, 2020

😅 Nice
Yeah that would be cool 👍

J12934
J12934 reviewed Jan 12, 2020
View reviewed changes
guides/aws/aws.md Outdated

```sh
#Associate IAM OIDC Provider
wget https://raw.githubusercontent.com/kubernetes-sigs/aws-alb-ingress-controller/v1.1.4/docs/examples/cluster-iam.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a 404 when trying to download https://raw.githubusercontent.com/kubernetes-sigs/aws-alb-ingress-controller/v1.1.4/docs/examples/cluster-iam.yaml.

The folder doesn't seem to contain a cluster-iam.yaml file: https://github.com/kubernetes-sigs/aws-alb-ingress-controller/tree/v1.1.4/docs/examples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also probably best to update the eks cluster to k8s 1.14 when using all the 1.14 resources.

Copy link
Contributor Author

@orangecola orangecola Jan 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I messed up. This link is supposed to point to the repo version.
I'll see if i can get the declarative version out before submitting another PR, as it will invalid this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay nice 👍

@J12934
Copy link
Member

J12934 commented Jan 17, 2020

👍 Will give it another try this weekend

@J12934
Copy link
Member

J12934 commented Jan 18, 2020

Got it running now 👍
Thank you very much 👏

@J12934 J12934 merged commit d41479a into juice-shop:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangecola @J12934