Simplify gem versioning #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on a single VERSION constant from judoscale-ruby, require that relatively to the specific lib gemspec so we can properly build the gem when releasing (which gets generated automatically via release-please). This means we don't need to "sync" gem versions anymore manually, or try to automate that as part of our release-please workflows, since there's a single source of truth for the version, and all libs share / release the same version anyway, even if there are no changes, let's just always require / use that single version file.
By keeping a single VERSION string/file, we don't need to sync versions across gems anymore.
carlosantoniodasilva
force-pushed
the
ca-simplify-versioning
branch
from
e4e67ca
to
7ee051a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #209, and is based on our discussion from a previous attempt in #208 (comment)
We currently keep gems in sync and bump all of them together to improve the experience and facilitate maintenance. However that required manually syncing versions before a release, and we were looking for ways to automate that step.
Instead, we're going to try eliminating the need to sync versions by having a single VERSION string, managed by judoscale-ruby, which gets automatically bumped by release-please for new releases. The gemspec and adapters were updated to refer to that single constant / source of truth, and gems will be built based on that, meaning bumping it will automatically work across all gems for new releases going forward.
It does make the fact that we report the same
adapter_versionacross all adapters a bit unnecessary, but it's not much overhead and it's consistent with other adapters. The only drawback is in case we decide to circle back on the decision to use the same version across the board, but we'll cross that bridge if it gets here.