Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and shorten gem summaries #206

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

carlosantoniodasilva
Copy link
Member

Remove specific mention of "Heroku add-on", simplify and make them short and sweet.

Ref: #204 (comment)

@@ -8,7 +8,7 @@ Gem::Specification.new do |spec|
spec.authors = ["Adam McCrea", "Carlos Antonio da Silva", "Jon Sullivan"]
spec.email = ["[email protected]"]

spec.summary = "This gem works with the Judoscale Heroku add-on to automatically scale your web and worker dynos."
spec.summary = "Autoscaling for Ruby."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wasn't sure if needed to add more, since it's the "core" gem that others depend on, so kept it simple. LMK if you want to expand it further.

Copy link
Collaborator

@adamlogic adamlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from ca-shoryuken-integration to main May 3, 2024 13:03
Remove specific mention of "Heroku add-on", simplify and make them short
and sweet.
@carlosantoniodasilva carlosantoniodasilva merged commit d6d9221 into main May 3, 2024
126 checks passed
@carlosantoniodasilva carlosantoniodasilva deleted the ca-gem-summary branch May 3, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants