Collect web metrics on all containers #177
Conversation
Worker containers don't receive requests, so they won't have web metrics to report anyway. The logic for suppressing the web metrics collector on worker containers was unnecessary. Removing this logic allows us to remove a bunch of other supporting code since the adapter doesn't actually care whether a container is web or worker.
| @@ -5,7 +5,6 @@ | |||
| "tasks": [ | |||
| { | |||
| "label": "test current gem", | |||
| "type": "shell", | |||
There was a problem hiding this comment.
Any notes on this? I don't know that I've used these but just curious
There was a problem hiding this comment.
I don't quite understand it, but this line was causing the task to use my system Ruby instead of my asdf Ruby. I removed it and things worked fine. 🤷♂️
There was a problem hiding this comment.
Huh. That's interesting! Neat!
| @@ -48,6 +48,7 @@ GEM | |||
| PLATFORMS | |||
| arm64-darwin-20 | |||
| arm64-darwin-21 | |||
| arm64-darwin-22 | |||
| def self.collect?(config) | ||
| config.current_runtime_container.web? | ||
| end |
There was a problem hiding this comment.
I'm not seeing the diff where this method was actually called 🤔
There was a problem hiding this comment.
The reporter calls it on every available metrics collector. It's defined in the superclass (MetricsCollector), so it'll always return true for WebMetricsCollector.
There was a problem hiding this comment.
It's defined in the superclass (MetricsCollector), so it'll always return true for WebMetricsCollector.
Got it, that makes sense!
Worker containers don't receive requests, so they won't have web metrics to report anyway. The logic for suppressing the web metrics collector on worker containers was unnecessary. Removing this logic allows us to remove a bunch of other supporting code since the adapter doesn't actually care whether a container is web or worker.