fix: Fail silently when DB or table is missing (#175)

judoscale · May 30, 2023 · 4e1cab6 · 4e1cab6
1 parent 9e7bfaa
commit 4e1cab6
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 0 deletions.
diff --git a/judoscale-delayed_job/lib/judoscale/delayed_job/metrics_collector.rb b/judoscale-delayed_job/lib/judoscale/delayed_job/metrics_collector.rb
@@ -30,6 +30,10 @@ def self.adapter_config
         Judoscale::Config.instance.delayed_job
       end
 
+      def self.collect?(config)
+        super && ActiveRecordHelper.table_exists?("delayed_jobs")
+      end
+
       def collect
         metrics = []
         t = Time.now.utc

diff --git a/judoscale-good_job/lib/judoscale/good_job/metrics_collector.rb b/judoscale-good_job/lib/judoscale/good_job/metrics_collector.rb
@@ -13,6 +13,10 @@ def self.adapter_config
         Judoscale::Config.instance.good_job
       end
 
+      def self.collect?(config)
+        super && ActiveRecordHelper.table_exists?("good_jobs")
+      end
+
       def initialize
         super
 

diff --git a/judoscale-que/lib/judoscale/que/metrics_collector.rb b/judoscale-que/lib/judoscale/que/metrics_collector.rb
@@ -38,6 +38,10 @@ def self.adapter_config
         Judoscale::Config.instance.que
       end
 
+      def self.collect?(config)
+        super && ActiveRecordHelper.table_exists?("que_jobs")
+      end
+
       def collect
         metrics = []
         t = Time.now.utc

diff --git a/judoscale-ruby/lib/judoscale/job_metrics_collector/active_record_helper.rb b/judoscale-ruby/lib/judoscale/job_metrics_collector/active_record_helper.rb
@@ -12,6 +12,12 @@ def self.cleanse_sql(sql)
         sql
       end
 
+      def self.table_exists?(table_name)
+        ::ActiveRecord::Base.connection.table_exists?(table_name)
+      rescue ActiveRecord::NoDatabaseError
+        false
+      end
+
       private
 
       def run_silently(&block)