Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify RuntimeContainer #67

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Simplify RuntimeContainer #67

merged 1 commit into from
Jul 18, 2023

Conversation

karls
Copy link
Collaborator

@karls karls commented Jul 17, 2023

Simplify RuntimeContainer as in judoscale/judoscale-ruby#178. Additionally, tighten up .should_collect.

adamlogic
adamlogic approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@adamlogic adamlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@karls karls merged commit 6d4e83d into main Jul 18, 2023
@karls karls deleted the simplify-runtime-container branch July 18, 2023 10:59
@karls karls mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamlogic adamlogic adamlogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karls @adamlogic