Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue posted on the JUCE forum concerning
-Wmissing-prototypes
warnings due to JACK (tested with Clang 10.0.0 & Ubuntu 20.04 - Clang 14.0.0 & Ubuntu 22.04.5 but warnings should appear on other OS.).Github Action
job-logs.txt
The commit 784ff78 declares the JACK methods as
static
to avoid these warnings. Two methods are only used in Debug mode, so they generate the-Wunused-function
warning in Release mode. The second commit c5eb15a corrects this problem by declaring them Debug-only.