Code analysis issues #1476
Open
Code analysis issues #1476
+130
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'isTicked' and 'hasSubMenu' (second on mac only) - Make enter open submenus if the submens are there - Change the "Ticked" spoken label to "Checked" The logic still isnt' quite right in 6.1.6; so apply patches to make our use case work at least and revisit later with JUCE team.
As discussed in surge-synthesizer/surge#6409 juce made the choice to SCALE mouse position in the vkb by overall velocity and we don't want that
* Allow building for RISC-V * Allow building for wasm Signed-off-by: falkTX <[email protected]> Merged against 7.0.5 by baconpaul Merged against 7.0.12 by baconpaul
As described in surge issue surge-synthesizer/surge#7281 the 'esc' key in Reaper VST3 does not get delivered to the plugin menu to close the menu, so accessible users with docked reaper windows get dumped out of surge when canceling menu actions. This doesn't fix that, but it adds an alternative that Shift-F10 also closes the menu (since that is our accessible open gesture).
…libc (surge-synthesizer#6) This commit squashes the four GLIBC/MUSL commits from juce-framework#1239 into our branch as a single commit (retaining a single commit to make future rebasing easier etc). Those commits were: * SystemStats: Only use locales on glibc * Linux: Add JUCE_GLIBC and JUCE_MUSL macros * SystemStats: Do not use execinfo.h on JUCE_MUSL * Native: Only use stat64 on glibc and iOS Musl 1.2.4 made the LFS64 interfaces only available when _LARGEFILE64_SOURCE is defined, and they will be removed altogether in Musl 1.2.5. --------- Co-authored-by: Violet Purcell <[email protected]> Rebase to 7.0.12 by baconpaul
Two simple case statement inclusions
…ches expected behaviour of Component::isShowing" This reverts commit 555b667.
per conversation with @reuk in forum oct 1
assert opcode before it's used. Don't fail to delete memory even though it's unlikely to occur. Handle situation when SHBrowseForFolder is cancelled (returns null). Several places appear to be checking the wrong thing after calling SafeArrayCreateVector.
|
Please can you provide some details about the code analysis you're running? Which tool are you using, and with what settings? |
|
@reuk Visual Studio code analysis & PVS-Studio - default settings. These are just a few that I've picked on while going over the Surge XT sources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert opcode before it's used.
Don't fail to delete memory even though it's unlikely to occur.
Handle situation when SHBrowseForFolder is cancelled (returns null).
Several places appear to be checking the wrong thing after calling SafeArrayCreateVector.