Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zookeeper version from 3.4.13 to 3.4.14 #72

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

bungoume
Copy link
Contributor

  • Update zookeeper version from 3.4.13 to 3.4.14
  • Change download url because riken will erase the old version immediately.

@rimms
Copy link
Member

rimms commented Feb 21, 2020

@bungoume Thank you. I will test this patch.

@rimms rimms self-assigned this Feb 21, 2020
@rimms
Copy link
Member

rimms commented Mar 16, 2020

I testing this patch on Ubuntu 16.04 (gcc 5.4.0).

cc1: error: -Werror=format-overflow: no option -Wformat-overflow

We want to support Ubuntu 16.04. Is -Wformat-overflow option required to build ZooKeeper?

@bungoume
Copy link
Contributor Author

-Wformat-overflow option required

yes,
GCC 8.3.0 (Debian buster) doesn't work without this option.

root@77f4aacb1d27:/jubatus-installer/download/zookeeper-3.4.14/zookeeper-client/zookeeper-client-c# make
make  all-am
make[1]: Entering directory '/jubatus-installer/download/zookeeper-3.4.14/zookeeper-client/zookeeper-client-c'
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated   -Wall -Werror  -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c  -fPIC -DPIC -o .libs/zookeeper.o
src/zookeeper.c: In function 'format_endpoint_info':
src/zookeeper.c:3506:21: error: '%d' directive writing between 1 and 5 bytes into a region of size between 0 and 127 [-Werror=format-overflow=]
     sprintf(buf,"%s:%d",addrstr,ntohs(port));
                     ^~
src/zookeeper.c:3506:17: note: directive argument in the range [0, 65535]
     sprintf(buf,"%s:%d",addrstr,ntohs(port));
                 ^~~~~~~
src/zookeeper.c:3506:5: note: 'sprintf' output between 3 and 134 bytes into a destination of size 128
     sprintf(buf,"%s:%d",addrstr,ntohs(port));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:947: zookeeper.lo] Error 1
make[1]: Leaving directory '/jubatus-installer/download/zookeeper-3.4.14/zookeeper-client/zookeeper-client-c'
make: *** [Makefile:622: all] Error 2

@bungoume
Copy link
Contributor Author

bungoume commented Mar 18, 2020

I removed the advanced parameter settings and now it works with GCC6 (and below).

@rimms rimms mentioned this pull request Mar 19, 2020
@rimms
Copy link
Member

rimms commented Mar 19, 2020

@bungoume Thank you. I raised a new Issue (#73).

@rimms rimms merged commit 1139d20 into jubatus:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants