One variant of convertor for the JavaScript (line) breakpoints. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult) files
1. Check that tests run clean with the base JDK (for this commit 17)
2. Remove all existing reference files:
find . -regextype egrep -regex '.*\.(occurrences|completion|folds|indexed|semantic|ccresult)' -exec rm {} \;
3. Rebuild the reference files by running unittests
4. Rerun unittests to verify all green
Return type from findAll changed from Collection to List
Workflow:
1. Update the groovy version
2. Remove all reference files:
find . -regextype egrep -regex '.*\.(occurrences|completion|folds|indexed|semantic|ccresult)' -exec rm {} \;
3. Rebuild the reference files by running the unittests with the base
JDK (17 for this commit)
4. Review the difference
5. Commit the change with the updated reference files
6. Add JDK specific variants by:
6a: Removing all existing reference files:
find . -regextype egrep -regex '.*\.(occurrences|completion|folds|indexed|semantic|ccresult)' -exec rm {} \;
6b: Rerun unittests with the target JDK
6c: Move the changed reference files to their version specific name
(21 is the JDK version in this case and needs to be adjusted):
for i in `git status -s | cut --delimiter " " -f 3`; do mv $i ${i%.*}.21.completion; git checkout $i; done
6d: Amend the changes to the base commit
Netbeans does support debugging of legacy Nashorn JavaScript engine bundled with OpenJDK < 15.0. It does not support the the most recent Nashorn 15.4 extracted from OpenJDK, that has different package name. Change allows debugging both legacy Nashorn JavaScript and also extracted Nashorn with new org.openjdk.nashorn package name. Co-authored-by: Matthias Bläsing <[email protected]>
[NETBEANS-7069] Support Nashorn 15.x for JDK >= 15
The implementation of GsfSemanticLayer#firstSequenceElement returns wrong/out-of-range values for the first element. This in turn causes tooltip/rendering errors when the sequence is used/positioned. Closes: apache#8102
csl.api: Fix GsfSemanticLayer after 0ba2e7a
It was observed, that custom @-rules failed to properly parse when
there was no whitespace present between the rule and the opening brace.
While this parsed:
@-ms-viewport {
width:1024px;
}
This was not:
@-ms-viewport{
width:1024px;
}
Updated spacers to - vertically center toolbar buttons - fix horizontal toolbar button positions - fix vertical approve/cancel button positions and reduce gap
…ition - adds tests to show the error - adds inner and outer record in ui template text for setting java format spaces - solves the error by moving spaces(cs.spaceWithinMethodDeclParens() ? 1 : 0, true); to the correct place. Co-authored-by: Michael Bien <[email protected]>
DirectoryChooserUI button position adjustments
- some internal methods are now public in FileSystemView and can be used instead of using reflection - remove calls to ShellFolder.getShellFolder(file) entirely this hopefully fixes the mysterious NPEs on windows caused by broken java.io.File instances with null paths.
…st-events Dispatch additional test events
Update Groovy libraries to 3.0.23
…ace-fix2 update formatter to handle record closing braces correctly
DirectoryChooserUI: reduce reflective win ShellFolder API usage
- moves about half of the code into a dedicated class - queries moved to NexusRepositoryQueries - index management remains in NexusRepositoryIndexManager
conditions: - both cache folders share the same parent - the cache folder is from an older release - the index itself is still somewhat up to date - current NB instance is not a dev build
…h the style of other NetBeans icons. The icons for OptionPane are 32x32 pixel version of the info/error/warning/question icons (scaled up from similar 16x16 SVG icons, but maintaining the 1px border width as this looks better). The icons for file chooser are "folder", "file", "parent folder", and "home folder". To keep the SVG loader module optional for NetBeans Platform apps, PNG versions of the icons are used here. SVG versions will be added in a separate commit (together with a bunch of other SVG files).
…on of the effort to make NetBeans look good on HiDPI/Retina screens. There are 107 new icons in total, copied into many more places where duplicate bitmap icons were identified. Some existing icons were also adjusted, and some existing icons were copied into new locations where additional duplicates were identified. I prioritized icons that are commonly seen in the IDE, and which happen to be easy to draw, as well as icons that are similar to already-drawn ones or simple variations or combinations thereof. The changes in this commit consist purely of copying SVG files into various locations in the repo; this was done by the hidpi-icons script at https://github.com/apache/netbeans-tools/tree/master/icon-scripts/hidpi-icons . I will open a separate Pull Request for that repo, to update the Adobe Illustrator file and icon mapping files. The 'icons.html' file that is generated by the hidpi-icons script is now included as part of the commit, in the root of the NetBeans repo. It includes a preamble with useful information and links to the README.
Maven remote index migration and refactoring
- apache#8035 - https://wiki.php.net/rfc#php_84 - https://wiki.php.net/todo/php84 - Add PHP 8.4 - Fix the available periods
- apache#8035 - https://wiki.php.net/rfc#php_84 - https://wiki.php.net/rfc/new_without_parentheses - Fix the gramar file(`ASTPHP5Parser.cup`) - Add the `PHP84UnhandledError` - Add unit tests for the parser Example: ```php new Example()->method(); new $class()?->method(); new Example()::staticMethod1()::CONSTANT; new (trim(' Example '))()::staticMethod1()->field; new Example()::{'CONSTANT'}; new Example()(); new $class()(); new Example()['key']; new $class()['key']; new (trim(' Example '))()['key']; // anonymous classes echo new class { const CONSTANT = 'constant'; }::CONSTANT; new class { public function method() {} }->method(); new class () implements ArrayAccess { }['key']; ```
- apache#8035 - https://wiki.php.net/rfc#php_84 - https://wiki.php.net/rfc/new_without_parentheses - Fix the formatter - Add `Other` to spaces within parentheses option e.g. `($a + $b);`, `new (trim(' Example '))()->field;` - Add/Fix unit tests
- apache#8035 - https://wiki.php.net/rfc#php_84 - https://wiki.php.net/rfc/new_without_parentheses - Fix "Go to Declaration" & "Mark Occurrences" - Add unit tests
- apache#8035 - https://wiki.php.net/rfc#php_84 - https://wiki.php.net/rfc/new_without_parentheses - Fix the `UnusedVariableHint` - Add a unit test
OCI Cloud Assets: Select OCI Profile should display correct region code.
…theses PHP 8.4 Support: new MyClass()->method() without parentheses
Add petrovic-d as collaborator for Apache/NetBeans
SYNCHRONIZE permission added to 'readWriteAcl' list
create new AclEntry if ownerEntry is not found
- apache#8035 - https://wiki.php.net/rfc#php_84 - https://wiki.php.net/rfc/deprecated_attribute - Fix/Improve `SemanticAnalysis` - Get deprecated attributes or phpdoc tags from ASTNodes(Attributes and PHPDoc comments) instead of getting deprecated flags from an index. That way, it should also improve performance. - Add the `IncorrectDeprecatedAttributeHintError` because "Deprecated" attribute cannot target type and field - Add unit tests for the navigator, hints, and semantic analysis
- Use `Set.contains()` instead of a for-each loop
PHP Documentation: Date: 6 Jan 2025 phpsigfiles-1.8
PHP 8.4 Support: #[\Deprecated] Attribute
Regenerate PHP signature files
…e_brace CSS: Improve parsing of custom @-rules
Warnings like this: [repeat] /home/bwalker/src/netbeans/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java:107: warning: [rawtypes] found raw type: Result [repeat] private Lookup.Result colorSource; [repeat] ^ [repeat] missing type arguments for generic class Result [repeat] where T is a type-variable: [repeat] T extends Object declared in class Result This pull request reduces many of those warnings.
Fix fabric8 license
Reduce warnings that look like this: [repeat] /home/bwalker/src/netbeans/enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java:144: warning: [rawtypes] found raw type: HashSet [repeat] private final Set<String> targetsStartedByIde = new HashSet(); // valued by target name [repeat] ^ [repeat] missing type arguments for generic class HashSet<E> [repeat] where E is a type-variable: [repeat] E extends Object declared in class HashSet
Fixing the build output appearance in vscode
new native win launcher - doesn't set hardcoded '-Djava.security.manager=allow' anymore - minor update release unix launcher script - move flag from launcher script to shared config file - flag can now be easily removed later
Update to Windows launcher (2-6c17cc6) and move security manager flag from launcher to config
Cleanup the few remaining HashSet warnings.. Reduce warnings that look like this: [repeat] /home/bwalker/src/netbeans/enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java:144: warning: [rawtypes] found raw type: HashSet [repeat] private final Set targetsStartedByIde = new HashSet(); // valued by target name [repeat] ^ [repeat] missing type arguments for generic class HashSet [repeat] where E is a type-variable: [repeat] E extends Object declared in class HashSet
Cleanup warnings that are related to the use of a Result raw type.. Warnings like this: [repeat] /home/bwalker/src/netbeans/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java:107: warning: [rawtypes] found raw type: Result [repeat] private Lookup.Result colorSource; [repeat] ^ [repeat] missing type arguments for generic class Result [repeat] where T is a type-variable: [repeat] T extends Object declared in class Result This pull request reduces many of those warnings.
…adapter Error handling for TestAdapter and DBConfigurationProvider
typo fix for apidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
#3
One alternative would be to have a bridge module between
javascript2.debugandlsp.client, but it seems wasteful for just one class. Hence this proxy approach.