Add ports column to certificate_associations table #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration Raven to sentry sdk migration
charhate
reviewed
May 7, 2021
lemur/certificates/models.py
Outdated
| ) | ||
| domain_id = Column(Integer, ForeignKey("domains.id"), primary_key=True) | ||
| certificate_id = Column(Integer, ForeignKey("certificates.id"), primary_key=True) | ||
| ports = Column(Text()) |
There was a problem hiding this comment.
I know this is just initial version, still one thought.
Postgres support integer array as data type. Are you planning to use that and is there a Column type for that instead of Text().
There was a problem hiding this comment.
Thanks, you're completely right about this. I realized as a result of this comment that I was never committing the changes to the DB - once I added the commit, it broke. Using an integer array column works perfectly.
Force source and destination delete to remove associations with certificate
jtschladen
changed the base branch from
expiring-deployed-certs-notification
to
certificate_associations-port-column
jtschladen
changed the base branch from
certificate_associations-port-column
to
expiring-deployed-certs-notification
Bumps [certbot](https://github.com/letsencrypt/letsencrypt) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/letsencrypt/letsencrypt/releases) - [Commits](certbot/certbot@v1.14.0...v1.15.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [boto3](https://github.com/boto/boto3) from 1.17.65 to 1.17.69. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.65...1.17.69) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.0.0 to 1.1.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.0.0...1.1.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [faker](https://github.com/joke2k/faker) from 8.1.2 to 8.1.3. - [Release notes](https://github.com/joke2k/faker/releases) - [Changelog](https://github.com/joke2k/faker/blob/master/CHANGELOG.md) - [Commits](joke2k/faker@v8.1.2...v8.1.3) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [botocore](https://github.com/boto/botocore) from 1.20.69 to 1.20.70. - [Release notes](https://github.com/boto/botocore/releases) - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.20.69...1.20.70) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [black](https://github.com/psf/black) from 21.5b0 to 21.5b1. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/commits) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pytest-mock](https://github.com/pytest-dev/pytest-mock) from 3.6.0 to 3.6.1. - [Release notes](https://github.com/pytest-dev/pytest-mock/releases) - [Changelog](https://github.com/pytest-dev/pytest-mock/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest-mock@v3.6.0...v3.6.1) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [hvac](https://github.com/hvac/hvac) from 0.10.10 to 0.10.11. - [Release notes](https://github.com/hvac/hvac/releases) - [Changelog](https://github.com/hvac/hvac/blob/develop/CHANGELOG.md) - [Commits](hvac/hvac@v0.10.10...v0.10.11) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [boto3](https://github.com/boto/boto3) from 1.17.69 to 1.17.70. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.69...1.17.70) Signed-off-by: dependabot[bot] <[email protected]>
…ons-port-column Add ports column to certificate_associations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.