Skip to content

Commit

Permalink
fix: Add --install-python=false to install invocation.
Browse files Browse the repository at this point in the history
The installer may attempt to install a Python package on MacOS,
if the versions do not line up with the minimum version blessed
by the script. To do this, it attempts to run sudo.

This disables the installation with an install flag.

The flag is present in all versions of gcloud since 352.0.0.

Fixes #82.
  • Loading branch information
fiadliel committed Oct 12, 2023
1 parent 2f63e19 commit b956493
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- [Dependencies](#dependencies)
- [Install](#install)
- [Why?](#why)
- [Supported Versions](#supported-versions)
- [Default Cloud SDK Components](#default-cloud-sdk-components)
- [Contributing](#contributing)
- [License](#license)
Expand Down Expand Up @@ -53,6 +54,10 @@ The asdf config file, `.tool-versions`, allows pinning each tool in your project

When you update a version in `.tool-versions`, `asdf` will prompt all users who do not have the correct versions to upgrade. This enables whole teams to update their tools in unison.

# Supported Versions

gcloud releases from 352.0.0 and higher can be installed.

# Default Cloud SDK Components

`asdf-gcloud` can automatically install a set of Cloud SDK Components after each `asdf install gcloud <version>`. To enable this feature you must have a file that lists one COMPONENT_ID per line. For example:
Expand Down
2 changes: 1 addition & 1 deletion bin/install
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ install_gcloud() {
log_success "extracted!"

log_info "🚧 installing..."
"${ASDF_INSTALL_PATH}/install.sh" --usage-reporting=false --path-update=false --quiet
"${ASDF_INSTALL_PATH}/install.sh" --usage-reporting=false --path-update=false --install-python=false --quiet
# test executable
test -x "${ASDF_INSTALL_PATH}/bin/gcloud" || log_failure_and_exit "Expected ${ASDF_INSTALL_PATH}/bin/gcloud to be executable."
log_success "gcloud ${ASDF_INSTALL_VERSION} installed!"
Expand Down

0 comments on commit b956493

Please sign in to comment.