Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change add customer logging support for cri container in windows platform. it extend the existing log_path property of the container definition. and make it support binary protocal (containerd have similar impementaion in linux plat).
for example now you can define in your contianerdef.json file
"log_path": "binary:d:\gosrc\bin\logger.exe"
at the time the container get create, the logger is launched automatically. today we use a fixed protocal for the logger, it will require following parameters
[stdout-pipename] [stderr-pipename] [liftime-signal-filename] [containerid] [labels]
the two named pipe is require to be host to receive the log pull out from hcsshim. and lifetime-signal] file is required to be create by the logger, and the logger then take responsible to watch the file, once the containerd shutdownt he container, it will delete the file, and logger take responsible to shutdown at that time. containerd will wait at most 10s to wait for logger shutdown, if not, it will kill the logger.
the other two parmeter is used to pass information into the customer logger.