Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressBar variants #517

Merged
merged 3 commits into from
Oct 25, 2024
Merged

ProgressBar variants #517

merged 3 commits into from
Oct 25, 2024

Conversation

sectore
Copy link
Contributor

@sectore sectore commented Oct 25, 2024 •
edited
Loading

Introduce progressBar' (note the ') customProgressBar to let users customize the ProgressBar.

Example: Using '▰' and '▱' draws following progress bar:

▰▰▰▰▰▰▰▰▰▰ 60% ▰▰▱▱▱▱▱▱▱▱

No api change.

Demo

(click image to see original size)

brick-custom-progressbar

jtdaugherty
jtdaugherty requested changes Oct 25, 2024
View reviewed changes
Copy link
Owner

@jtdaugherty jtdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes! I've left some comments.

programs/ProgressBarDemo.hs Show resolved Hide resolved
programs/ProgressBarDemo.hs Outdated Show resolved Hide resolved
src/Brick/Widgets/ProgressBar.hs Outdated Show resolved Hide resolved
src/Brick/Widgets/ProgressBar.hs Outdated Show resolved Hide resolved
src/Brick/Widgets/ProgressBar.hs Outdated Show resolved Hide resolved
src/Brick/Widgets/ProgressBar.hs Outdated Show resolved Hide resolved
src/Brick/Widgets/ProgressBar.hs Outdated Show resolved Hide resolved
@jtdaugherty jtdaugherty merged commit e461db5 into jtdaugherty:master Oct 25, 2024
0 of 10 checks passed
@jtdaugherty
Copy link
Owner

Thank you!

@jtdaugherty
Copy link
Owner

These changes are now released in 2.5.

@sectore sectore deleted the feat/progressbar-variants branch October 26, 2024 09:07
@sectore sectore mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtdaugherty jtdaugherty jtdaugherty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sectore @jtdaugherty