Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash from FileBrowser initial directory specification. #508

Merged
merged 1 commit into from
May 7, 2024

Conversation

kquick
Copy link
Contributor

@kquick kquick commented May 7, 2024

If the FileBrowser is initialized with a FilePath that ends in a slash, then if the user hits Enter on the "../" entry to move to the parent directory, the only effect is the removal of that trailing slash. This is relatively unexpected and likely to be unnoticed by the user, possibly leading them to believe that the move-to-parent-directory operation did not work.

Once the trailing slash is removed, the expected move occurs whenever the "../" entry is invoked, and the current path never ends in a trailing slash.

This patch simply removes the trailing slash(es) from the user-supplied FilePath (although it will leave "/" untouched).

@jtdaugherty jtdaugherty merged commit 764e668 into jtdaugherty:master May 7, 2024
10 checks passed
@jtdaugherty
Copy link
Owner

Thank you!

@jtdaugherty
Copy link
Owner

This is now released in 2.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants