Adding in support for generating an ISO8601 datetime string that includes milliseconds #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udes milliseconds - e.g. calls Date.toISOString() as currently the 'iso' format leaves that off which makes it unsuitable for certain use cases. For backwards compatibility this commit adds this in if a new 'isoSS' format is specified.
|
Key here is I needed the date not only to be generated with millisecond precision, but also to be generated in the UTC timezone, not my local timezone. I couldn't figure out a way to achieve both of those things without this change. Please close this PR if this change is unnecessary and there is an existing way to achieve this. |
|
Bumping this as just installed your plugin on my new machine and wondered why it wasn't working - I forgot I installed my fork last time. Be great to get this merged in. I just confirmed it still works by manually editing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not the best way to implement this, but this change is backwards compatible and unblocked me as I needed a genuine ISO8601 datetime string that included milliseconds - e.g. calls
Date.toISOString()- as currently the 'iso' format leaves that off which makes it unsuitable for certain use cases.For backwards compatibility this commit adds this in if a new 'isoSS' format is specified.
Submitting this PR in case it helps anyone else.