Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker runtime and some env configurations #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stopka
Copy link

@Stopka Stopka commented Mar 5, 2022

Hi, I made it runnable as a standalone app in docker.

For this reason I also made few features configurable by environment variables:

  • BOSH_URL if set it hides the bosh input in login form and uses it's value
  • SERVICE_WORKER if true the service worker is registered, otherwise it is unregistered
  • SECURE_HOSTNAME you can define other hostname as secure, defaults to localhost (usefull if you use proxy in local environment with domains in form of example.localhost)
  • ENVIRONMENT_SECURITY_MODE you can set if the app refuses to start as before (strict), or it should just shows a warning (lax). It also can warn you once and persist your choice (persistent)

I made these changes for my usecase, but if you like it, here is the pull request. ;)

@sualko
Copy link
Member

sualko commented Mar 8, 2022

That is awesome 👏. Thanks a lot. I will merge this as soon as I have time to upgrade this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants