-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] create ignorePrivate option for no-multi-comp rule #3842
Draft
vwillyams
wants to merge
14
commits into
jsx-eslint:master
Choose a base branch
from
vwillyams:export-only-multi-comp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
40cdaaa
create exportOnly rule for no-multi-comp
vwillyams a4fb0a4
flesh out tests and docs
vwillyams da04e17
logic fixes
vwillyams 23c5e34
silly logic oversight
vwillyams 27d8075
fix docs, change name to ignorePrivate
vwillyams 9c03d56
Update lib/rules/no-multi-comp.js
vwillyams 34d2e33
Update lib/rules/no-multi-comp.js
vwillyams 82b4da7
Update docs/rules/no-multi-comp.md
vwillyams 6655950
clean up github commit suggestions
vwillyams b420cb5
PR suggested changes
vwillyams cf6a63f
major rewrite of test code, fixed a couple of missing cases. awaiting…
vwillyams cb7e496
hopefully resolve syntax issues with combinatorial testing
vwillyams e852af0
fix syntax
vwillyams 82ea0aa
more syntax goofing, should really figure out local test runs
vwillyams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe in react 19, async functions can be components as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point, I had not thought about RSCs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a little coverage for this - I'm not an RSC dev by day though so may have made some oversights.