feature: Option to not striping whitespaces from texts of cells. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkit-jain
requested changes
Sep 28, 2020
There was a problem hiding this comment.
Thanks for the PR @AysegulKarcili. I don't imagine the PR breaking anything, but, could you please add a test case that demonstrates the need for this in which the test would pass on your branch but fail on the jsvine:stable branch? Please remove any sensitive information from the PDF that you are not comfortable sharing.
|
Yes, thanks for suggesting this @AysegulKarcili. Seems like a nice and simple feature. One other small request: Could you rename the parameter to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: Option to extract text of cells with leading and trailing white spaces preserved #277