Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to add limits and requests to debug pods #21

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

lalitmsft
Copy link
Contributor

@lalitmsft lalitmsft commented Nov 23, 2023

Feat:

  • Add option to specify resource requests and limits for debug pods

Standalone Usage without plugin

Creating debug pods without requests and limits

./kubectl-windows-debug <node-name>

Creating debug pods with requests and limits

./kubectl-windows-debug -r "cpu=100m,memory=256Mi" -l "cpu=200m,memory=512Mi" <node-name>

Creating debug pods with req only requests

./kubectl-windows-debug -r "cpu=100m,memory=256Mi" <node-name>

Creating debug pods with only limits

./kubectl-windows-debug -l "cpu=200m,memory=512Mi" <node-name>

@jsturtevant
Copy link
Owner

@lalitmsft thanks!

Will you add a section to the -h parameter describing the new parameters?

@jsturtevant
Copy link
Owner

don't worry about the CI failure. It is due to permissions of the github action, which will only work when I trigger it :-/

@jsturtevant jsturtevant merged commit b2e7b09 into jsturtevant:main Nov 29, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants