test: use IsExact of @std/testing #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IsExact` false positives have been fixed in @std/[email protected]. denoland/std#5676
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 52 52
Lines 954 954
Branches 120 120
=======================================
Hits 953 953
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Milly
commented
Sep 7, 2024
| assertType<IsExact<() => any, () => number>>(true); | ||
| assertType<IsExact<Foo<any>, Foo<number>>>(true); | ||
| assertType<IsExact<{ a: 1 }, { readonly a: 1 }>>(true); | ||
| }); |
There was a problem hiding this comment.
This test now fails once we update @std/testing to 1.0.1 or higher, which is expected.
lambdalisue
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsExactfalse positives have been fixed in @std/[email protected].This PR only changes test, no code changes.