Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[isTupleOf]: add overloads to leading/middle rest elements #119

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

Milly
Copy link
Collaborator

@Milly Milly commented Aug 12, 2024

Typescript tuple types can define leading or middle rest elements.
Added corresponding overloads to isTupleOf().

@Milly Milly added the enhancement New feature or request label Aug 12, 2024
@Milly Milly requested a review from lambdalisue August 12, 2024 08:21
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (ae3696d) to head (1e80cdd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   99.54%   99.88%   +0.34%     
==========================================
  Files          50       50              
  Lines         874      908      +34     
  Branches       92      103      +11     
==========================================
+ Hits          870      907      +37     
+ Misses          4        1       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Milly Milly force-pushed the tuple-rest branch 2 times, most recently from ccb2c61 to 4633df6 Compare August 12, 2024 08:38
@Milly Milly changed the title feat[isTupleOf]: add overloads to forward/middle rest elements feat[isTupleOf]: add overloads to leading/middle rest elements Aug 12, 2024
is/tuple_of.ts Outdated Show resolved Hide resolved
is/tuple_of.ts Outdated Show resolved Hide resolved
is/tuple_of_test.ts Outdated Show resolved Hide resolved
is/tuple_of_test.ts Outdated Show resolved Hide resolved
@Milly Milly marked this pull request as draft August 13, 2024 09:11
@Milly Milly marked this pull request as ready for review August 13, 2024 09:54
@Milly Milly requested a review from lambdalisue August 13, 2024 09:54
@Milly
Copy link
Collaborator Author

Milly commented Aug 13, 2024

Rebased include #122.
Because tuple type testing is false positive before it PR.

@lambdalisue lambdalisue merged commit d0f6737 into main Aug 13, 2024
6 checks passed
@lambdalisue lambdalisue deleted the tuple-rest branch August 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants